Modify agressive service restart timer#48
Open
gregorybel wants to merge 5 commits intojamorham:masterfrom
Open
Modify agressive service restart timer#48gregorybel wants to merge 5 commits intojamorham:masterfrom
gregorybel wants to merge 5 commits intojamorham:masterfrom
Conversation
Update fork master
Updatemaster
merge master
- add some logs
Contributor
Author
|
@jamorham any questions or remarks? |
Owner
|
This looks like it will modify more than the aggressive restart timer due to the way the missed readings service is structured. What is the purpose of this PR, what issue is it designed to resolve or feature to implement? |
Contributor
Author
|
I see several issues:
I thought combining both restart and missed reading would make sence. @jamorham which issue do you see doing this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use Missed Reading timer instead of a fix 5min timer.
Like this each has possibility to use a different timer.
I suggest using 6min for example.
Tested successfully.
PS: sorry PR is not so clean due to old commits.... :-)